Re: [PATCH v4 4/7] net: phy: Add 10BASE-T1L support in phy-c45

From: alexandru.tachici
Date: Wed Feb 09 2022 - 11:07:28 EST


> On Sat, Dec 11, 2021 at 10:07:49PM +0100, Andrew Lunn wrote:
> > > + ret = phy_read_mmd(phydev, MDIO_MMD_PMAPMD, MDIO_PMA_EXTABLE);
> > > + if (ret < 0)
> > > + return ret;
> > > +
> > > + if (ret & MDIO_PMA_EXTABLE_BT1)
> >
> >
> > This pattern of reading the MDIO_PMA_EXTABLE register and then looking
> > for bit MDIO_PMA_EXTABLE_BT1 happens a lot. It is not something which
> > is expected to change is it? So i wounder if it should be read once
> > and stored away?
>
> What is the state of this patches? Will you be able to make requested
> changes and send new version?

I will come back with a V5 where I will add the requested changes.

Regards,
Alexandru