Re: [PATCH] spi: initialize ret variable

[Tom Rix]

On 2/9/22 8:33 AM, Mark Brown wrote:
> On Wed, Feb 09, 2022 at 08:30:29AM -0800, trix@xxxxxxxxxx wrote:
> > From: Tom Rix <trix@xxxxxxxxxx>
> >
> > Clang build fails with
> > spi-sunplus-sp7021.c:405:2: error: variable 'ret' is used
> >    uninitialized whenever switch default is taken
> >          default:
> >          ^~~~~~~
> >
> > Restore initializing ret.
> Are you sure this is a good fix and that the compiler hasn't instead
> identifed that we should be returning an error in the default case?

If setting mode to idle is not really a valid state, then default should 
return an error.

The old behavior returned 0 and I am treating this as a regression.

Tom