Re: [PATCH net] net: phy: mediatek: remove PHY mode check on MT7531

[Hauke Mehrtens]

On 2/9/22 15:39, DENG Qingfang wrote:
> The function mt7531_phy_mode_supported in the DSA driver set supported
> mode to PHY_INTERFACE_MODE_GMII instead of PHY_INTERFACE_MODE_INTERNAL
> for the internal PHY, so this check breaks the PHY initialization:
>
> mt7530 mdio-bus:00 wan (uninitialized): failed to connect to PHY: -EINVAL
>
> Remove the check to make it work again.
>
> Reported-by: Hauke Mehrtens <hauke@xxxxxxxxxx>
> Fixes: e40d2cca0189 ("net: phy: add MediaTek Gigabit Ethernet PHY driver")
> Signed-off-by: DENG Qingfang <dqfext@xxxxxxxxx>

Tested-by: Hauke Mehrtens <hauke@xxxxxxxxxx>

> ---
>   drivers/net/phy/mediatek-ge.c | 3 ---
>   1 file changed, 3 deletions(-)
>
> diff --git a/drivers/net/phy/mediatek-ge.c b/drivers/net/phy/mediatek-ge.c
> index b7a5ae20edd5..68ee434f9dea 100644
> --- a/drivers/net/phy/mediatek-ge.c
> +++ b/drivers/net/phy/mediatek-ge.c
> @@ -55,9 +55,6 @@ static int mt7530_phy_config_init(struct phy_device *phydev)
>   
>   static int mt7531_phy_config_init(struct phy_device *phydev)
>   {
> -	if (phydev->interface != PHY_INTERFACE_MODE_INTERNAL)
> -		return -EINVAL;
> -
>   	mtk_gephy_config_init(phydev);
>   
>   	/* PHY link down power saving enable */