Re: [PATCH] drm/msm/rd: Add chip-id

[Dmitry Baryshkov]

On 14/01/2022 21:57, Rob Clark wrote:
> From: Rob Clark <robdclark@xxxxxxxxxxxx>
>
> For newer devices which deprecate gpu-id and do matching based on
> chip-id, we need this information in cmdstream dumps so that the
> decoding tools know how to decode them.
>
> Signed-off-by: Rob Clark <robdclark@xxxxxxxxxxxx>

Reviewed-by: Dmitry Baryshkov <dmitry.baryshkov@xxxxxxxxxx>

> ---
>   drivers/gpu/drm/msm/msm_rd.c | 4 ++++
>   1 file changed, 4 insertions(+)
>
> diff --git a/drivers/gpu/drm/msm/msm_rd.c b/drivers/gpu/drm/msm/msm_rd.c
> index 81432ec07012..7e4d6460719e 100644
> --- a/drivers/gpu/drm/msm/msm_rd.c
> +++ b/drivers/gpu/drm/msm/msm_rd.c
> @@ -62,6 +62,7 @@ enum rd_sect_type {
>   	RD_FRAG_SHADER,
>   	RD_BUFFER_CONTENTS,
>   	RD_GPU_ID,
> +	RD_CHIP_ID,
>   };
>   
>   #define BUF_SZ 512  /* should be power of 2 */
> @@ -202,6 +203,9 @@ static int rd_open(struct inode *inode, struct file *file)
>   
>   	rd_write_section(rd, RD_GPU_ID, &gpu_id, sizeof(gpu_id));
>   
> +	gpu->funcs->get_param(gpu, MSM_PARAM_CHIP_ID, &val);
> +	rd_write_section(rd, RD_CHIP_ID, &val, sizeof(val));
> +
>   out:
>   	mutex_unlock(&gpu->lock);
>   	return ret;


--
With best wishes
Dmitry