Re: [PATCH v1] audit: fix illegal pointer dereference for openat2

From: Paul Moore
Date: Wed Feb 09 2022 - 20:29:27 EST


On Wed, Feb 9, 2022 at 4:51 PM Richard Guy Briggs <rgb@xxxxxxxxxx> wrote:
>
> The user pointer was being illegally dereferenced directly to get the
> open_how flags data in audit_match_perm. Use the previously saved flags
> data elsewhere in the context instead.
>
> Coverage is provided by the audit-testsuite syscalls_file test case.
>
> Cc: stable@xxxxxxxxxxxxxxx
> Link: https://lore.kernel.org/r/c96031b4-b76d-d82c-e232-1cccbbf71946@xxxxxxxx
> Fixes: 1c30e3af8a79 ("audit: add support for the openat2 syscall")
> Reported-by: Jeff Mahoney <jeffm@xxxxxxxx>
> Signed-off-by: Richard Guy Briggs <rgb@xxxxxxxxxx>
> ---
> kernel/auditsc.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)

Thanks Richard. As this came in ~40m after the other patch, and both
are identical code changes, I've merged the other patch but I did add
a note that you also submitted a similar patch. Once the automated
testing completes I'll send this up to Linus.

--
paul-moore.com