Re: [PATCH] ASoC: qcom: Actually clear DMA interrupt register for HDMI

From: Mark Brown
Date: Thu Feb 10 2022 - 08:38:21 EST


On Wed, 9 Feb 2022 15:25:20 -0800, Stephen Boyd wrote:
> In commit da0363f7bfd3 ("ASoC: qcom: Fix for DMA interrupt clear reg
> overwriting") we changed regmap_write() to regmap_update_bits() so that
> we can avoid overwriting bits that we didn't intend to modify.
> Unfortunately this change breaks the case where a register is writable
> but not readable, which is exactly how the HDMI irq clear register is
> designed (grep around LPASS_HDMITX_APP_IRQCLEAR_REG to see how it's
> write only). That's because regmap_update_bits() tries to read the
> register from the hardware and if it isn't readable it looks in the
> regmap cache to see what was written there last time to compare against
> what we want to write there. Eventually, we're unable to modify this
> register at all because the bits that we're trying to set are already
> set in the cache.
>
> [...]

Applied to

https://git.kernel.org/pub/scm/linux/kernel/git/broonie/sound.git for-linus

Thanks!

[1/1] ASoC: qcom: Actually clear DMA interrupt register for HDMI
commit: c8d251f51ee61df06ee0e419348d8c9160bbfb86

All being well this means that it will be integrated into the linux-next
tree (usually sometime in the next 24 hours) and sent to Linus during
the next merge window (or sooner if it is a bug fix), however if
problems are discovered then the patch may be dropped or reverted.

You may get further e-mails resulting from automated or manual testing
and review of the tree, please engage with people reporting problems and
send followup patches addressing any issues that are reported if needed.

If any updates are required or you are submitting further changes they
should be sent as incremental updates against current git, existing
patches will not be replaced.

Please add any relevant lists and maintainers to the CCs when replying
to this mail.

Thanks,
Mark