Re: [PATCH] nfp: flower: Fix a potential theorical leak in nfp_tunnel_add_shared_mac()

[Christophe JAILLET]

Le 10/02/2022 à 14:04, Simon Horman a écrit :
> Hi Christophe,
>
> On Wed, Feb 09, 2022 at 07:58:47PM +0100, Christophe JAILLET wrote:
> > ida_simple_get() returns an id between min (0) and max (NFP_MAX_MAC_INDEX)
> > inclusive.
> > So NFP_MAX_MAC_INDEX (0xff) is a valid id
> >
> > In order for the error handling path to work correctly, the 'invalid'
> > value for 'ida_idx' should not be in the 0..NFP_MAX_MAC_INDEX range,
> > inclusive.
> >
> > So set it to -1.
> >
> > While at it, use ida_alloc_xxx()/ida_free() instead to
> > ida_simple_get()/ida_simple_remove().
> > The latter is deprecated and more verbose.
> >
> > Fixes: 20cce8865098 ("nfp: flower: enable MAC address sharing for offloadable devs")
> > Signed-off-by: Christophe JAILLET <christophe.jaillet@xxxxxxxxxx>
>
> Thanks for your patch.
>
> I agree that it is indeed a problem and your fix looks good.
> I would, however, prefer if the patch was split into two:
>
> 1. Bug fix
> 2. ida_alloc_xxx()/ida_free() cleanup

I'll send a v2.

I added it because some other maintainers have asked for it in other 
similar patches. Everyone's taste is different :).

CJ



> Thanks again,
> Simon
>
> ...