Re: [PATCH 3/3] KVM: SVM: fix race between interrupt delivery and AVIC inhibition

From: Sean Christopherson
Date: Fri Feb 11 2022 - 12:35:49 EST


On Fri, Feb 11, 2022, Paolo Bonzini wrote:
> On 2/11/22 18:11, Sean Christopherson wrote:
> > > + /* Process the interrupt with a vmexit. */
> >
> > Double spaces at the end. But I would prefer we omit the comment entirely,
> > there is no guarantee the vCPU is in the guest or even running.
>
> Sure, or perhaps "process the interrupt in inject_pending_event".

s/in/via?

> Regarding the two spaces, it used to a pretty strict rule in the US with
> typewriters. It helps readability of monospaced fonts
> (https://www.cultofpedagogy.com/two-spaces-after-period/), and code is
> mostly monospaced... But well, the title of the article says it all.

Preaching to the choir, I'm a firm believer that there should always be two spaces
after a full stop, monospace or not. Unless it's the end of a comment. :-D