Re: [PATCH 00/11] PCI: mvebu: subsystem ids, AER and INTx

From: Lorenzo Pieralisi
Date: Fri Feb 11 2022 - 12:51:01 EST


On Wed, Jan 05, 2022 at 04:02:28PM +0100, Pali Rohár wrote:
> This patch series extends pci-bridge-emul.c driver to emulate PCI Subsystem
> Vendor ID capability and PCIe extended capabilities. And then implement
> in pci-mvebu.c driver support for PCI Subsystem Vendor IDs, PCIe AER
> registers, support for legacy INTx interrupts, configuration for X1/X4
> mode and usage of new PCI child_ops API.
>
> This patch series depends on other pci-mvebu and pci-bridge-emul patches from:
> https://lore.kernel.org/linux-pci/20220104153529.31647-1-pali@xxxxxxxxxx/
Hi Pali,

I went through the series quickly and I don't think there is anything
controversial, posted some minor comments. Do not repost yet, I will
be back at v5.17-rc5 and work towards merging it for v5.18.

Lorenzo

>
> Pali Rohár (9):
> PCI: pci-bridge-emul: Add support for PCI Bridge Subsystem Vendor ID
> capability
> dt-bindings: PCI: mvebu: Add num-lanes property
> PCI: mvebu: Correctly configure x1/x4 mode
> PCI: mvebu: Add support for PCI Bridge Subsystem Vendor ID on emulated
> bridge
> PCI: mvebu: Add support for Advanced Error Reporting registers on
> emulated bridge
> PCI: mvebu: Use child_ops API
> dt-bindings: PCI: mvebu: Update information about intx interrupts
> PCI: mvebu: Implement support for legacy INTx interrupts
> ARM: dts: armada-385.dtsi: Add definitions for PCIe legacy INTx
> interrupts
>
> Russell King (2):
> PCI: pci-bridge-emul: Re-arrange register tests
> PCI: pci-bridge-emul: Add support for PCIe extended capabilities
>
> .../devicetree/bindings/pci/mvebu-pci.txt | 16 +
> arch/arm/boot/dts/armada-385.dtsi | 52 ++-
> drivers/pci/controller/pci-mvebu.c | 352 +++++++++++++++---
> drivers/pci/pci-bridge-emul.c | 167 ++++++---
> drivers/pci/pci-bridge-emul.h | 17 +
> 5 files changed, 494 insertions(+), 110 deletions(-)
>
> --
> 2.20.1
>