Re: [PATCH] net: Fix build when CONFIG_INET is not enabled

[Ricardo Ribalda]

Hi Eric

I failed to find that patch. I only searched in linus/master. Please
ignore mine.

Thanks.

On Fri, 11 Feb 2022 at 18:24, Eric Dumazet <edumazet@xxxxxxxxxx> wrote:
>
> On Fri, Feb 11, 2022 at 8:40 AM Ricardo Ribalda <ribalda@xxxxxxxxxxxx> wrote:
> >
> > If the kernel is configured with CONFIG_NET, but without CONFIG_INET we
> > get the following error when building:
> >
> > sock.c:(.text+0x4c17): undefined reference to `__sk_defer_free_flush'
> >
> > Lets move __sk_defer_free_flush to sock.c
> >
>
> deja vu ?
>
> commit 48cec899e357cfb92d022a9c0df6bbe72a7f6951
> Author: Gal Pressman <gal@xxxxxxxxxx>
> Date:   Thu Jan 20 14:34:40 2022 +0200
>
>     tcp: Add a stub for sk_defer_free_flush()
>
>     When compiling the kernel with CONFIG_INET disabled, the
>     sk_defer_free_flush() should be defined as a nop.
>
>     This resolves the following compilation error:
>       ld: net/core/sock.o: in function `sk_defer_free_flush':
>       ./include/net/tcp.h:1378: undefined reference to `__sk_defer_free_flush'
>
>     Fixes: 79074a72d335 ("net: Flush deferred skb free on socket destroy")
>     Reported-by: kernel test robot <lkp@xxxxxxxxx>
>     Reviewed-by: Tariq Toukan <tariqt@xxxxxxxxxx>
>     Signed-off-by: Gal Pressman <gal@xxxxxxxxxx>
>     Reviewed-by: Eric Dumazet <edumazet@xxxxxxxxxx>
>     Link: https://lore.kernel.org/r/20220120123440.9088-1-gal@xxxxxxxxxx
>     Signed-off-by: Jakub Kicinski <kuba@xxxxxxxxxx>



-- 
Ricardo Ribalda