Re: [PATCH v4 1/2] leds: ktd20xx: Extension of the KTD20xx family of LED drivers from Kinetic
From: Pavel Machek
Date: Sat Feb 12 2022 - 07:11:10 EST
Hi!
> > + struct device *dev = &chip->client->dev;
> > + int ret;
> > + unsigned int value;
>
> Here and everywhere can you use reverse xmas tree ordering?
>
> struct device *dev = &chip->client->dev;
> unsigned int value;
> int ret;
Lets not ask people to do that.
Best regards,
Pavel
--
http://www.livejournal.com/~pavelmachek
Attachment:
signature.asc
Description: PGP signature