Re: [PATCH 5/6] dt-bindings: spi: support mediatek,need_ahb_clk flag

From: Leilk Liu
Date: Sun Feb 13 2022 - 20:53:48 EST


On Fri, 2022-02-11 at 10:59 -0600, Rob Herring wrote:
> On Wed, Feb 09, 2022 at 07:19:37PM +0800, Leilk Liu wrote:
> > this patch support mediatek,need_ahb_clk flag.
> >
> > Signed-off-by: Leilk Liu <leilk.liu@xxxxxxxxxxxx>
> > ---
> > .../devicetree/bindings/spi/mediatek,spi-mt65xx.yaml | 5
> > +++++
> > 1 file changed, 5 insertions(+)
> >
> > diff --git a/Documentation/devicetree/bindings/spi/mediatek,spi-
> > mt65xx.yaml b/Documentation/devicetree/bindings/spi/mediatek,spi-
> > mt65xx.yaml
> > index 241c0f5880d3..af12c1711182 100644
> > --- a/Documentation/devicetree/bindings/spi/mediatek,spi-
> > mt65xx.yaml
> > +++ b/Documentation/devicetree/bindings/spi/mediatek,spi-
> > mt65xx.yaml
> > @@ -71,6 +71,11 @@ properties:
> > specify which pins group(ck/mi/mo/cs) spi controller used.
> > This is an array.
> >
> > + mediatek,need_ahb_clk:
>
> s/_/-/
>
> But really, this should be implied by the compatible string or
> presence
> of the clock in 'clocks'.
so I can only add "spi-hclk" in clocks' and don't need
"mediatek,need_ahb_clk" again? thanks

>
> Rob