Re: [PATCH v3 3/3] pinctrl: canonical rsel resistance selection property

[Guodong Liu]

-----Original Message-----
From: AngeloGioacchino Del Regno <
angelogioacchino.delregno@xxxxxxxxxxxxx>
To: Guodong Liu <guodong.liu@xxxxxxxxxxxx>, Linus Walleij <
linus.walleij@xxxxxxxxxx>, Rob Herring <robh+dt@xxxxxxxxxx>, Matthias
Brugger <matthias.bgg@xxxxxxxxx>, Sean Wang <sean.wang@xxxxxxxxxx>
Cc: Sean Wang <sean.wang@xxxxxxxxxxxx>, linux-gpio@xxxxxxxxxxxxxxx, 
devicetree@xxxxxxxxxxxxxxx, linux-arm-kernel@xxxxxxxxxxxxxxxxxxx, 
linux-mediatek@xxxxxxxxxxxxxxxxxxx, linux-kernel@xxxxxxxxxxxxxxx, 
Project_Global_Chrome_Upstream_Group@xxxxxxxxxxxx
Subject: Re: [PATCH v3 3/3] pinctrl: canonical rsel resistance
selection property
Date: Thu, 10 Feb 2022 09:50:45 +0100

Il 10/02/22 07:21, Guodong Liu ha scritto:
> Change "mediatek,rsel_resistance_in_si_unit" to "mediatek,rsel-
> resistance-in-si-unit"
> 
> Signed-off-by: Guodong Liu <guodong.liu@xxxxxxxxxxxx>

Hello Guodong,
thanks for the patch!

However, you forgot to add the required Fixes tag to this one; this
patch
should be fixing fb34a9ae383a ("pinctrl: mediatek: support rsel
feature").

Please add the required tag.

Thanks,
Angelo

Hi Angelo

We will update it for next version.

Thanks
Guodong
> ---
>   drivers/pinctrl/mediatek/pinctrl-paris.c | 2 +-
>   1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/drivers/pinctrl/mediatek/pinctrl-paris.c
> b/drivers/pinctrl/mediatek/pinctrl-paris.c
> index d4e02c5d74a8..38c0f0c4cf95 100644
> --- a/drivers/pinctrl/mediatek/pinctrl-paris.c
> +++ b/drivers/pinctrl/mediatek/pinctrl-paris.c
> @@ -989,7 +989,7 @@ int mtk_paris_pinctrl_probe(struct
> platform_device *pdev,
>   	hw->nbase = hw->soc->nbase_names;
>   
>   	if (of_find_property(hw->dev->of_node,
> -			     "mediatek,rsel_resistance_in_si_unit",
> NULL))
> +			     "mediatek,rsel-resistance-in-si-unit",
> NULL))
>   		hw->rsel_si_unit = true;
>   	else
>   		hw->rsel_si_unit = false;
>