Re: [PATCH 13/23] drm/rockchip: Make use of the helper component_compare_dev

From: Heiko Stübner
Date: Mon Feb 14 2022 - 03:03:28 EST


Am Montag, 14. Februar 2022, 07:08:09 CET schrieb Yong Wu:
> Use the common compare helper from component.
>
> Cc: Sandy Huang <hjc@xxxxxxxxxxxxxx>
> Cc: "Heiko St¨¹bner" <heiko@xxxxxxxxx>
> Cc: linux-rockchip@xxxxxxxxxxxxxxxxxxx
> Signed-off-by: Yong Wu <yong.wu@xxxxxxxxxxxx>

Acked-by: Heiko Stuebner <heiko@xxxxxxxxx>

> ---
> drivers/gpu/drm/rockchip/rockchip_drm_drv.c | 7 +------
> 1 file changed, 1 insertion(+), 6 deletions(-)
>
> diff --git a/drivers/gpu/drm/rockchip/rockchip_drm_drv.c b/drivers/gpu/drm/rockchip/rockchip_drm_drv.c
> index bec207de4544..3c2f2d6ecc36 100644
> --- a/drivers/gpu/drm/rockchip/rockchip_drm_drv.c
> +++ b/drivers/gpu/drm/rockchip/rockchip_drm_drv.c
> @@ -290,11 +290,6 @@ int rockchip_drm_endpoint_is_subdriver(struct device_node *ep)
> return false;
> }
>
> -static int compare_dev(struct device *dev, void *data)
> -{
> - return dev == (struct device *)data;
> -}
> -
> static void rockchip_drm_match_remove(struct device *dev)
> {
> struct device_link *link;
> @@ -321,7 +316,7 @@ static struct component_match *rockchip_drm_match_add(struct device *dev)
> break;
>
> device_link_add(dev, d, DL_FLAG_STATELESS);
> - component_match_add(dev, &match, compare_dev, d);
> + component_match_add(dev, &match, component_compare_dev, d);
> } while (true);
> }
>
>