Re: [PATCH -next] i2c: designware: remove unneeded semicolon

[Jan Dąbroś]

pon., 14 lut 2022 o 02:03 Yang Li <yang.lee@xxxxxxxxxxxxxxxxx> napisał(a):
>
> Eliminate the following coccicheck warning:
> ./drivers/i2c/busses/i2c-designware-amdpsp.c:248:2-3: Unneeded semicolon
>
> Reported-by: Abaci Robot <abaci@xxxxxxxxxxxxxxxxx>
> Signed-off-by: Yang Li <yang.lee@xxxxxxxxxxxxxxxxx>
> ---
>  drivers/i2c/busses/i2c-designware-amdpsp.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/i2c/busses/i2c-designware-amdpsp.c b/drivers/i2c/busses/i2c-designware-amdpsp.c
> index 752e0024db03..f589d3a1a19e 100644
> --- a/drivers/i2c/busses/i2c-designware-amdpsp.c
> +++ b/drivers/i2c/busses/i2c-designware-amdpsp.c
> @@ -245,7 +245,7 @@ static int psp_acquire_i2c_bus(void)
>         if (psp_i2c_access_count) {
>                 psp_i2c_access_count++;
>                 goto cleanup;
> -       };
> +       }

Thanks. While fixing this, please do the same for the 'switch' in
check_i2c_req_sts() function above. Isn't your tool reporting this?

Best Regards,
Jan