Re: [PATCH] PM: domains: Prevent power off for parent unless child is in deepest state

[Ulf Hansson]

On Sun, 13 Feb 2022 at 13:14, Dmitry Osipenko <digetx@xxxxxxxxx> wrote:
>
> 07.02.2022 11:43, Ulf Hansson пишет:
> >> In general, such changes usually are deferred from being upstreamed
> >> until there is a real user, otherwise there is a risk of cluttering the
> >> code with unused features. Do you have a time estimation in regards to
> >> when STMicro may start to benefit from this change?
> > The STMicro folkz are working on it right now, but I can't give you
> > any estimates for their work.
> >
> > Moreover, I think the important point in this regard, is that the
> > $subject patch doesn't really hurt anything else, so then what's the
> > point of holding this back?
>
> If that work will never pan out, will you remove the unused code?

Sure, I will continue to monitor the situation, which is what I have
been doing for many years by now.

In the past we have agreed to add new things to genpd, even if those
didn't have in-tree users when the changes went in. The current
dev_pm_genpd_set_next_wakeup() inteface, for example, is still lacking
a user upstream. It's a balance, because I certainly agree with you,
that we don't want to carry around dead code in the kernel - unless we
have reasons to believe it's an intermediate step before there a user
turning up.

Kind regards
Uffe