Re: [PATCH 00/12] i2c-hid: fixes for unnumbered reports and other improvements

From: Jiri Kosina
Date: Mon Feb 14 2022 - 05:03:29 EST


On Thu, 3 Feb 2022, Benjamin Tissoires wrote:

> OK, So I applied the series on my development laptop.
> I had to apply it on top of v5.16 and then rebase on top of
> hid.git/for-next because there is a minor conflict.
>
> I changed the register as mentioned in 5/12, and gave it a try.
> Both the Elan touchpad and the Wacom panel on my XPS-13 are behaving
> properly, suspend/resume works also as expected.
>
> Tested-by: Benjamin Tissoires <benjamin.tissoires@xxxxxxxxxx>
>
> I gave a quick look at the individual patches, they all seem sane to
> me, but haven't dug into enough detail to be able to formally give my
> reviewed-by.
> Note that I have a small comment on patch 2, but if you want to apply
> it nevertheless Jiri (with the change in 5/12) it should be fine.

Thanks a lot for testing. I've tested in on my I2C hardware, and haven't
spotted any issues either.

I plan to finish going through the whole set today and tomorrow, and apply
it right afterwards with the 5/12 change.

Thanks,

--
Jiri Kosina
SUSE Labs