Re: [PATCH v4 3/3] pinctrl: canonical rsel resistance selection property

[AngeloGioacchino Del Regno]

Il 14/02/22 04:06, Guodong Liu ha scritto:
> Change "mediatek,rsel_resistance_in_si_unit" to
> "mediatek,rsel-resistance-in-si-unit"
>
> Fixes: fb34a9ae383a ("pinctrl: mediatek: support rsel feature")
> Signed-off-by: Guodong Liu <guodong.liu@xxxxxxxxxxxx>

A note for maintainers: luckily, this property hasn't been used in any device-tree
yet, so we luckily (since naming convention was not compliant) don't have to worry
about retro-compatibility for old DTs; so...

Reviewed-by: AngeloGioacchino Del Regno <angelogioacchino.delregno@xxxxxxxxxxxxx>

> ---
>   drivers/pinctrl/mediatek/pinctrl-paris.c | 2 +-
>   1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/pinctrl/mediatek/pinctrl-paris.c b/drivers/pinctrl/mediatek/pinctrl-paris.c
> index d4e02c5d74a8..38c0f0c4cf95 100644
> --- a/drivers/pinctrl/mediatek/pinctrl-paris.c
> +++ b/drivers/pinctrl/mediatek/pinctrl-paris.c
> @@ -989,7 +989,7 @@ int mtk_paris_pinctrl_probe(struct platform_device *pdev,
>   	hw->nbase = hw->soc->nbase_names;
>   
>   	if (of_find_property(hw->dev->of_node,
> -			     "mediatek,rsel_resistance_in_si_unit", NULL))
> +			     "mediatek,rsel-resistance-in-si-unit", NULL))
>   		hw->rsel_si_unit = true;
>   	else
>   		hw->rsel_si_unit = false;