Re: [PATCH] iommu/amd: Fix I/O page table memory leak

From: Joerg Roedel
Date: Mon Feb 14 2022 - 06:53:00 EST


On Thu, Feb 10, 2022 at 09:47:45AM -0600, Suravee Suthikulpanit wrote:
> The current logic updates the I/O page table mode for the domain
> before calling the logic to free memory used for the page table.
> This results in IOMMU page table memory leak, and can be observed
> when launching VM w/ pass-through devices.
>
> Fix by freeing the memory used for page table before updating the mode.
>
> Cc: Joerg Roedel <joro@xxxxxxxxxx>
> Reported-by: Daniel Jordan <daniel.m.jordan@xxxxxxxxxx>
> Tested-by: Daniel Jordan <daniel.m.jordan@xxxxxxxxxx>
> Signed-off-by: Suravee Suthikulpanit <suravee.suthikulpanit@xxxxxxx>
> Fixes: e42ba0633064 ("iommu/amd: Restructure code for freeing page table")
> Link: https://lore.kernel.org/all/20220118194720.urjgi73b7c3tq2o6@xxxxxxxxxx/
> ---
> drivers/iommu/amd/io_pgtable.c | 12 ++++++------
> 1 file changed, 6 insertions(+), 6 deletions(-)

Applied, thanks.