Re: [PATCH 1/2] pwm: pwm-mediatek: Simplify error handling with dev_err_probe()

[AngeloGioacchino Del Regno]

Il 14/02/22 14:48, Uwe Kleine-König ha scritto:
> On Mon, Feb 14, 2022 at 12:30:37PM +0100, AngeloGioacchino Del Regno wrote:
> > Use dev_err_probe() to simplify handling errors in pwm_mediatek_probe().
> >
> > Signed-off-by: AngeloGioacchino Del Regno <angelogioacchino.delregno@xxxxxxxxxxxxx>
> > ---
> >   drivers/pwm/pwm-mediatek.c | 30 +++++++++++-------------------
> >   1 file changed, 11 insertions(+), 19 deletions(-)
> >
> > diff --git a/drivers/pwm/pwm-mediatek.c b/drivers/pwm/pwm-mediatek.c
> > index 0d4dd80e9f07..c7d5ca09a684 100644
> > --- a/drivers/pwm/pwm-mediatek.c
> > +++ b/drivers/pwm/pwm-mediatek.c
> > @@ -227,18 +227,14 @@ static int pwm_mediatek_probe(struct platform_device *pdev)
> >   		return -ENOMEM;
> >   
> >   	pc->clk_top = devm_clk_get(&pdev->dev, "top");
> > -	if (IS_ERR(pc->clk_top)) {
> > -		dev_err(&pdev->dev, "clock: top fail: %ld\n",
> > -			PTR_ERR(pc->clk_top));
> > -		return PTR_ERR(pc->clk_top);
> > -	}
> > +	if (IS_ERR(pc->clk_top))
> > +		return dev_err_probe(&pdev->dev, PTR_ERR(pc->clk_top),
> > +				     "clock: top failed\n");
>
> The change looks straight forward. I wonder if we should improve the
> error message on this occasion. E.g.
>
> 	"Failed to get top clock\n"

I can push another commit on top that improves the messages, if desired!

Regards,
Angelo

> ? Ditto below.
>
> Best regards
> Uwe