Re: [PATCH V7 2/3] tools arch x86: Add Intel SDSi provisiong tool

[David E. Box]

On Mon, 2022-02-14 at 11:56 +0100, Hans de Goede wrote:
> Hi,
> 
> On 2/12/22 02:32, David E. Box wrote:
> > Add tool for key certificate and activation payload provisioning on
> > Intel CPUs supporting Software Defined Silicon (SDSi).
> > 
> > Signed-off-by: David E. Box <david.e.box@xxxxxxxxxxxxxxx>
> > ---
> > V7
> >   - No changes.
> > V6
> >   - No changes.
> > V5
> >   - Update copyright to 2022
> > V4
> >   - No changes.
> > V3
> >   - Move from samples to tools.
> >   - Fix bit fields in availability structure.
> >   - Check provisioning availability before issuing command.
> > 
> > V2
> >   - New patch.
> > 
> >  MAINTAINERS                        |   1 +
> >  tools/arch/x86/intel_sdsi/Makefile |   9 +
> >  tools/arch/x86/intel_sdsi/sdsi.c   | 540 +++++++++++++++++++++++++++++
> >  3 files changed, 550 insertions(+)
> >  create mode 100644 tools/arch/x86/intel_sdsi/Makefile
> >  create mode 100644 tools/arch/x86/intel_sdsi/sdsi.c
> > 
> > diff --git a/MAINTAINERS b/MAINTAINERS
> > index 29d0945f5a63..80325cbde3bd 100644
> > --- a/MAINTAINERS
> > +++ b/MAINTAINERS
> > @@ -9873,6 +9873,7 @@ INTEL SDSI DRIVER
> >  M:     David E. Box <david.e.box@xxxxxxxxxxxxxxx>
> >  S:     Supported
> >  F:     drivers/platform/x86/intel/sdsi.c
> > +F:     tools/arch/x86/intel_sdsi/
> >  
> >  INTEL SKYLAKE INT3472 ACPI DEVICE DRIVER
> >  M:     Daniel Scally <djrscally@xxxxxxxxx>
> > diff --git a/tools/arch/x86/intel_sdsi/Makefile
> > b/tools/arch/x86/intel_sdsi/Makefile
> > new file mode 100644
> > index 000000000000..1c2d102ff8fb
> > --- /dev/null
> > +++ b/tools/arch/x86/intel_sdsi/Makefile
> > @@ -0,0 +1,9 @@
> > +# SPDX-License-Identifier: GPL-2.0
> > +
> > +.PHONY: sdsi
> > +
> > +sdsi: sdsi.o
> > +       $(CC) -Wall $^ -o $@
> > +
> > +clean:
> > +       rm *.o sdsi
> 
> I assume that this is also going to be an official tool (next to a UI one?)
> which users may use to provision AKCs and CAPs ?
> 
> In that case the binary really should also be named intel_sdsi like the
> directory
> and an install target should be added, see for example how:
> 
> tools/arch/x86/kcpuid/Makefile
> 
> does this.

Will do.

David