Re: [PATCH 2/2] perf jevents: Add support for HiSilicon CPA PMU aliasing

[liuqi (BA)]

On 2022/2/14 20:04, John Garry wrote:
> On 14/02/2022 11:42, Qi Liu wrote:
> > Add support for HiSilicon CPA PMU aliasing.
> >
> > The kernel driver is in drivers/perf/hisilicon/hisi_uncore_cpa_pmu.c
> >
> > Signed-off-by: Qi Liu<liuqi115@xxxxxxxxxx>
>
> You realy should cc the perf tool list and maintainers there also.
>
> Reviewed-by: John Garry <john.garry@xxxxxxxxxx>
>
> > +    },
> > +    {
> > +        "MetricExpr": "(p0_wr_dat * 64 + p0_rd_dat_64b * 64 + 
> > p0_rd_dat_32b * 32) / cpa_cycles",
> > +        "BriefDescription": "Average bandwidth of CPA Port 0",
> > +        "MetricGroup": "CPA",
Hi john,

> nit: maybe this should have a more distrinct name

got it, will change metric's name next version.

> > +        "MetricName": "p0_avg_bw",
> > +        "Compat": "0x00000030",
>
> JFYI, I have a rewrite of the perf tool system pmu metric support that 
> will not require us to add the compat here.
great! I'm very glad to test it using CPA PMU.

Thanks,
Qi
> > +        "Unit": "hisi_sicl,cpa"
>
> Thanks,
> John
> .