Re: [PATCH 3/8] sched: Move rt_period/runtime sysctls to rt.c
From: kernel test robot
Date: Tue Feb 15 2022 - 02:47:56 EST
Hi Zhen,
Thank you for the patch! Yet something to improve:
[auto build test ERROR on tip/sched/core]
[also build test ERROR on linus/master kees/for-next/pstore v5.17-rc4]
[cannot apply to next-20220214]
[If your patch is applied to the wrong git tree, kindly drop us a note.
And when submitting patch, we suggest to use '--base' as documented in
https://git-scm.com/docs/git-format-patch]
url: https://github.com/0day-ci/linux/commits/Zhen-Ni/sched-Move-a-series-of-sysctls-starting-with-sys-kernel-sched_/20220215-132416
base: https://git.kernel.org/pub/scm/linux/kernel/git/tip/tip.git 3624ba7b5e2acc02b01301ea5fd3534971eb9896
config: parisc-randconfig-r023-20220214 (https://download.01.org/0day-ci/archive/20220215/202202151509.TszSxsaB-lkp@xxxxxxxxx/config)
compiler: hppa-linux-gcc (GCC) 11.2.0
reproduce (this is a W=1 build):
wget https://raw.githubusercontent.com/intel/lkp-tests/master/sbin/make.cross -O ~/bin/make.cross
chmod +x ~/bin/make.cross
# https://github.com/0day-ci/linux/commit/f93266963b3b3629980fa3384a5e37fd13f4c350
git remote add linux-review https://github.com/0day-ci/linux
git fetch --no-tags linux-review Zhen-Ni/sched-Move-a-series-of-sysctls-starting-with-sys-kernel-sched_/20220215-132416
git checkout f93266963b3b3629980fa3384a5e37fd13f4c350
# save the config file to linux build tree
mkdir build_dir
COMPILER_INSTALL_PATH=$HOME/0day COMPILER=gcc-11.2.0 make.cross O=build_dir ARCH=parisc SHELL=/bin/bash kernel/rcu/
If you fix the issue, kindly add following tag as appropriate
Reported-by: kernel test robot <lkp@xxxxxxxxx>
All errors (new ones prefixed by >>):
kernel/rcu/rcutorture.c: In function 'rcu_torture_disable_rt_throttle':
>> kernel/rcu/rcutorture.c:921:26: error: 'sysctl_sched_rt_runtime' undeclared (first use in this function); did you mean 'sysctl_sched_rr_timeslice'?
921 | old_rt_runtime = sysctl_sched_rt_runtime;
| ^~~~~~~~~~~~~~~~~~~~~~~
| sysctl_sched_rr_timeslice
kernel/rcu/rcutorture.c:921:26: note: each undeclared identifier is reported only once for each function it appears in
kernel/rcu/rcutorture.c: In function 'rcu_torture_enable_rt_throttle':
kernel/rcu/rcutorture.c:930:9: error: 'sysctl_sched_rt_runtime' undeclared (first use in this function); did you mean 'sysctl_sched_rr_timeslice'?
930 | sysctl_sched_rt_runtime = old_rt_runtime;
| ^~~~~~~~~~~~~~~~~~~~~~~
| sysctl_sched_rr_timeslice
vim +921 kernel/rcu/rcutorture.c
450efca7182a51 Joel Fernandes (Google 2018-06-10 909)
450efca7182a51 Joel Fernandes (Google 2018-06-10 910) static void rcu_torture_disable_rt_throttle(void)
450efca7182a51 Joel Fernandes (Google 2018-06-10 911) {
450efca7182a51 Joel Fernandes (Google 2018-06-10 912) /*
450efca7182a51 Joel Fernandes (Google 2018-06-10 913) * Disable RT throttling so that rcutorture's boost threads don't get
450efca7182a51 Joel Fernandes (Google 2018-06-10 914) * throttled. Only possible if rcutorture is built-in otherwise the
450efca7182a51 Joel Fernandes (Google 2018-06-10 915) * user should manually do this by setting the sched_rt_period_us and
450efca7182a51 Joel Fernandes (Google 2018-06-10 916) * sched_rt_runtime sysctls.
450efca7182a51 Joel Fernandes (Google 2018-06-10 917) */
450efca7182a51 Joel Fernandes (Google 2018-06-10 918) if (!IS_BUILTIN(CONFIG_RCU_TORTURE_TEST) || old_rt_runtime != -1)
450efca7182a51 Joel Fernandes (Google 2018-06-10 919) return;
450efca7182a51 Joel Fernandes (Google 2018-06-10 920)
450efca7182a51 Joel Fernandes (Google 2018-06-10 @921) old_rt_runtime = sysctl_sched_rt_runtime;
450efca7182a51 Joel Fernandes (Google 2018-06-10 922) sysctl_sched_rt_runtime = -1;
450efca7182a51 Joel Fernandes (Google 2018-06-10 923) }
450efca7182a51 Joel Fernandes (Google 2018-06-10 924)
---
0-DAY CI Kernel Test Service, Intel Corporation
https://lists.01.org/hyperkitty/list/kbuild-all@xxxxxxxxxxxx