Re: [v1 01/16] dt-bindings: ARM: Mediatek: Add new document bindings of MT8186 clock

From: Chun-Jie Chen
Date: Tue Feb 15 2022 - 05:24:21 EST

Next message: Greg Kroah-Hartman: "Re: [char-misc 1/4] mei: me: disable driver on the ign firmware"
Previous message: Anup Patel: "Re: [PATCH v3 4/6] RISC-V: Implement multi-letter ISA extension probing framework"
In reply to: Chun-Jie Chen: "Re: [v1 01/16] dt-bindings: ARM: Mediatek: Add new document bindings of MT8186 clock"
Messages sorted by: [ date ] [ thread ] [ subject ] [ author ]

On Wed, 2022-02-09 at 09:40 +0800, Chun-Jie Chen wrote:
> On Fri, 2022-01-21 at 18:25 -0600, Rob Herring wrote:
> > On Mon, Jan 10, 2022 at 09:44:01PM +0800, Chun-Jie Chen wrote:
> > > This patch adds the new binding documentation for system clock
> > > and functional clock on Mediatek MT8186.
> > >
> > > Signed-off-by: Chun-Jie Chen <chun-jie.chen@xxxxxxxxxxxx>
> > > ---
> > > .../arm/mediatek/mediatek,mt8186-clock.yaml | 133
> > > ++++++++++++++++++
> > > .../mediatek/mediatek,mt8186-sys-clock.yaml | 74 ++++++++++
> > > 2 files changed, 207 insertions(+)
> > > create mode 100644
> > > Documentation/devicetree/bindings/arm/mediatek/mediatek,mt8186-
> > > clock.yaml
> > > create mode 100644
> > > Documentation/devicetree/bindings/arm/mediatek/mediatek,mt8186-
> > > sys-
> > > clock.yaml
> > >
> > > diff --git
> > > a/Documentation/devicetree/bindings/arm/mediatek/mediatek,mt8186-
> > > clock.yaml
> > > b/Documentation/devicetree/bindings/arm/mediatek/mediatek,mt8186-
> > > clock.yaml
> > > new file mode 100644
> > > index 000000000000..fc39101bc9b0
> > > --- /dev/null
> > > +++
> > > b/Documentation/devicetree/bindings/arm/mediatek/mediatek,mt8186-
> > > clock.yaml
> > > @@ -0,0 +1,133 @@
> > > +# SPDX-License-Identifier: (GPL-2.0 OR BSD-2-Clause)
> > > +%YAML 1.2
> > > +---
> > > +$id: "
> > >
https://urldefense.com/v3/__http://devicetree.org/schemas/arm/mediatek/mediatek,mt8186-clock.yaml*__;Iw!!CTRNKA9wMg0ARbw!3pIyNVU0grMb7zKVQZoRO2z-eKrg6FnGcieEON8cCw84G6_W7Tt4GEFwytcYEXyrcj6e$
> > > "
> > > +$schema: "
> > >
https://urldefense.com/v3/__http://devicetree.org/meta-schemas/core.yaml*__;Iw!!CTRNKA9wMg0ARbw!3pIyNVU0grMb7zKVQZoRO2z-eKrg6FnGcieEON8cCw84G6_W7Tt4GEFwytcYEUOCCW1i$
> > > "
> > > +
> > > +title: Mediatek Functional Clock Controller for MT8186
> > > +
> > > +maintainers:
> > > + - Chun-Jie Chen <chun-jie.chen@xxxxxxxxxxxx>
> > > +
> > > +description:
> > > + The clock architecture in Mediatek like below
> > > + PLLs -->
> > > + dividers -->
> > > + muxes
> > > + -->
> > > + clock gate
> > > +
> > > + The devices provide clock gate control in different IP blocks.
> > > +
> > > +properties:
> > > + compatible:
> > > + items:
> > > + - enum:
> > > + - mediatek,mt8186-imp_iic_wrap
> > > + - mediatek,mt8186-mfgsys
> > > + - mediatek,mt8186-wpesys
> > > + - mediatek,mt8186-imgsys1
> > > + - mediatek,mt8186-imgsys2
> > > + - mediatek,mt8186-vdecsys
> > > + - mediatek,mt8186-vencsys
> > > + - mediatek,mt8186-camsys
> > > + - mediatek,mt8186-camsys_rawa
> > > + - mediatek,mt8186-camsys_rawb
> > > + - mediatek,mt8186-mdpsys
> > > + - mediatek,mt8186-ipesys
> > > + reg:
> > > + maxItems: 1
> > > +
> > > + '#clock-cells':
> > > + const: 1
> > > +
> > > +required:
> > > + - compatible
> > > + - reg
> > > +
> > > +additionalProperties: false
> > > +
> > > +examples:
> > > + - |
> > > + imp_iic_wrap: clock-controller@11017000 {
> > > + compatible = "mediatek,mt8186-imp_iic_wrap";
> > > + reg = <0x11017000 0x1000>;
> > > + #clock-cells = <1>;
> > > + };
> > > +
> > > + - |
> > > + mfgsys: clock-controller@13000000 {
> > > + compatible = "mediatek,mt8186-mfgsys";
> > > + reg = <0x13000000 0x1000>;
> > > + #clock-cells = <1>;
> > > + };
> > > +
> > > + - |
> > > + wpesys: clock-controller@14020000 {
> > > + compatible = "mediatek,mt8186-wpesys";
> > > + reg = <0x14020000 0x1000>;
> > > + #clock-cells = <1>;
> > > + };
> > > +
> > > + - |
> > > + imgsys1: clock-controller@15020000 {
> > > + compatible = "mediatek,mt8186-imgsys1";
> > > + reg = <0x15020000 0x1000>;
> > > + #clock-cells = <1>;
> > > + };
> > > +
> > > + - |
> > > + imgsys2: clock-controller@15820000 {
> > > + compatible = "mediatek,mt8186-imgsys2";
> > > + reg = <0x15820000 0x1000>;
> > > + #clock-cells = <1>;
> > > + };
> > > +
> > > + - |
> > > + vdecsys: clock-controller@1602f000 {
> > > + compatible = "mediatek,mt8186-vdecsys";
> > > + reg = <0x1602f000 0x1000>;
> > > + #clock-cells = <1>;
> > > + };
> > > +
> > > + - |
> > > + vencsys: clock-controller@17000000 {
> > > + compatible = "mediatek,mt8186-vencsys";
> > > + reg = <0x17000000 0x1000>;
> > > + #clock-cells = <1>;
> > > + };
> > > +
> > > + - |
> > > + camsys: clock-controller@1a000000 {
> > > + compatible = "mediatek,mt8186-camsys";
> > > + reg = <0x1a000000 0x1000>;
> > > + #clock-cells = <1>;
> > > + };
> > > +
> > > + - |
> > > + camsys_rawa: clock-controller@1a04f000 {
> > > + compatible = "mediatek,mt8186-camsys_rawa";
> > > + reg = <0x1a04f000 0x1000>;
> > > + #clock-cells = <1>;
> > > + };
> > > +
> > > + - |
> > > + camsys_rawb: clock-controller@1a06f000 {
> > > + compatible = "mediatek,mt8186-camsys_rawb";
> > > + reg = <0x1a06f000 0x1000>;
> > > + #clock-cells = <1>;
> > > + };
> > > +
> > > + - |
> > > + mdpsys: clock-controller@1b000000 {
> > > + compatible = "mediatek,mt8186-mdpsys";
> > > + reg = <0x1b000000 0x1000>;
> > > + #clock-cells = <1>;
> > > + };
> > > +
> > > + - |
> > > + ipesys: clock-controller@1c000000 {
> > > + compatible = "mediatek,mt8186-ipesys";
> > > + reg = <0x1c000000 0x1000>;
> > > + #clock-cells = <1>;
> > > + };
> >
> > There's little point in enumerating every possible compatible. 1
> > example
> > is more than enough.
> >
> >
>
> Ok, I will fix it in next patch.
>
> > > diff --git
> > > a/Documentation/devicetree/bindings/arm/mediatek/mediatek,mt8186-
> > > sys-clock.yaml
> > > b/Documentation/devicetree/bindings/arm/mediatek/mediatek,mt8186-
> > > sys-clock.yaml
> > > new file mode 100644
> > > index 000000000000..11473971a165
> > > --- /dev/null
> > > +++
> > > b/Documentation/devicetree/bindings/arm/mediatek/mediatek,mt8186-
> > > sys-clock.yaml
> > > @@ -0,0 +1,74 @@
> > > +# SPDX-License-Identifier: (GPL-2.0 OR BSD-2-Clause)
> > > +%YAML 1.2
> > > +---
> > > +$id: "
> > >
https://urldefense.com/v3/__http://devicetree.org/schemas/arm/mediatek/mediatek,mt8186-sys-clock.yaml*__;Iw!!CTRNKA9wMg0ARbw!3pIyNVU0grMb7zKVQZoRO2z-eKrg6FnGcieEON8cCw84G6_W7Tt4GEFwytcYERailYtq$
> > > "
> > > +$schema: "
> > >
https://urldefense.com/v3/__http://devicetree.org/meta-schemas/core.yaml*__;Iw!!CTRNKA9wMg0ARbw!3pIyNVU0grMb7zKVQZoRO2z-eKrg6FnGcieEON8cCw84G6_W7Tt4GEFwytcYEUOCCW1i$
> > > "
> > > +
> > > +title: Mediatek System Clock Controller for MT8186
> > > +
> > > +maintainers:
> > > + - Chun-Jie Chen <chun-jie.chen@xxxxxxxxxxxx>
> > > +
> > > +description:
> > > + The clock architecture in Mediatek like below
> > > + PLLs -->
> > > + dividers -->
> > > + muxes
> > > + -->
> > > + clock gate
> > > +
> > > + The apmixedsys provides most of PLLs which generated from SoC
> > > 26m.
> > > + The topckgen provides dividers and muxes which provide the
> > > clock
> > > source to other IP blocks.
> > > + The infracfg_ao provides clock gate in peripheral and
> > > infrastructure IP blocks.
> > > + The mcusys provides mux control to select the clock source in
> > > AP
> > > MCU.
> > > +
> > > +properties:
> > > + compatible:
> > > + items:
> > > + - enum:
> > > + - mediatek,mt8186-mcusys
> > > + - mediatek,mt8186-topckgen
> > > + - mediatek,mt8186-infracfg_ao
> > > + - mediatek,mt8186-apmixedsys
> > > + - const: syscon
> > > +
> > > + reg:
> > > + maxItems: 1
> > > +
> > > + '#clock-cells':
> > > + const: 1
> > > +
> > > +required:
> > > + - compatible
> > > + - reg
> > > +
> > > +additionalProperties: false
> > > +
> > > +examples:
> > > + - |
> > > + mcusys: syscon@c53a000 {
> >
> > clock-controller@...
> >
> > Drop unused labels.
> >
>
> Ok, I will change to pure clock-controller
>
> Thanks!
> Best Regards,
> Chun-Jie
>

Please skip the reply above.

The devices in this binding document also support system configuration
not only pure clock provider, so make them as "syscon".

Thanks!
Best Regards,
Chun-Jie

> > > + compatible = "mediatek,mt8186-mcusys", "syscon";
> > > + reg = <0xc53a000 0x1000>;
> > > + #clock-cells = <1>;
> > > + };
> > > +
> > > + - |
> > > + topckgen: syscon@10000000 {
> > > + compatible = "mediatek,mt8186-topckgen", "syscon";
> > > + reg = <0x10000000 0x1000>;
> > > + #clock-cells = <1>;
> > > + };
> > > +
> > > + - |
> > > + infracfg_ao: syscon@10001000 {
> > > + compatible = "mediatek,mt8186-infracfg_ao", "syscon";
> > > + reg = <0x10001000 0x1000>;
> > > + #clock-cells = <1>;
> > > + };
> > > +
> > > + - |
> > > + apmixedsys: syscon@1000c000 {
> > > + compatible = "mediatek,mt8186-apmixedsys", "syscon";
> > > + reg = <0x1000c000 0x1000>;
> > > + #clock-cells = <1>;
> > > + };
> >
> > Again, 1 example is enough.

Next message: Greg Kroah-Hartman: "Re: [char-misc 1/4] mei: me: disable driver on the ign firmware"
Previous message: Anup Patel: "Re: [PATCH v3 4/6] RISC-V: Implement multi-letter ISA extension probing framework"
In reply to: Chun-Jie Chen: "Re: [v1 01/16] dt-bindings: ARM: Mediatek: Add new document bindings of MT8186 clock"
Messages sorted by: [ date ] [ thread ] [ subject ] [ author ]