[PATCH net-next 13/19] net: dev: use kfree_skb_reason() for sch_handle_egress()

From: menglong8 . dong
Date: Tue Feb 15 2022 - 06:32:58 EST


From: Menglong Dong <imagedong@xxxxxxxxxxx>

Replace kfree_skb() used in sch_handle_egress() with kfree_skb_reason().
The drop reason SKB_DROP_REASON_QDISC_EGRESS is introduced. Considering
the code path of qdisc egress, we make it distinct with the drop reason
of SKB_DROP_REASON_QDISC_DROP in the next commit.

Signed-off-by: Menglong Dong <imagedong@xxxxxxxxxxx>
---
include/linux/skbuff.h | 4 ++++
include/trace/events/skb.h | 1 +
net/core/dev.c | 2 +-
3 files changed, 6 insertions(+), 1 deletion(-)

diff --git a/include/linux/skbuff.h b/include/linux/skbuff.h
index 136af29be256..9e19806d9818 100644
--- a/include/linux/skbuff.h
+++ b/include/linux/skbuff.h
@@ -396,6 +396,10 @@ enum skb_drop_reason {
* full, and the skbs on the
* tail will be dropped
*/
+ SKB_DROP_REASON_QDISC_EGRESS, /* qdisc of type egress check
+ * failed (maybe an eBPF program
+ * is tricking?)
+ */
SKB_DROP_REASON_MAX,
};

diff --git a/include/trace/events/skb.h b/include/trace/events/skb.h
index dd06366ded4a..a79b64eace9e 100644
--- a/include/trace/events/skb.h
+++ b/include/trace/events/skb.h
@@ -43,6 +43,7 @@
EM(SKB_DROP_REASON_IPV6DSIABLED, IPV6DSIABLED) \
EM(SKB_DROP_REASON_NEIGH_FAILED, NEIGH_FAILED) \
EM(SKB_DROP_REASON_NEIGH_QUEUEFULL, NEIGH_QUEUEFULL) \
+ EM(SKB_DROP_REASON_QDISC_EGRESS, QDISC_EGRESS) \
EMe(SKB_DROP_REASON_MAX, MAX)

#undef EM
diff --git a/net/core/dev.c b/net/core/dev.c
index 2c3b8744e00c..2a7b7c1b855a 100644
--- a/net/core/dev.c
+++ b/net/core/dev.c
@@ -3840,7 +3840,7 @@ sch_handle_egress(struct sk_buff *skb, int *ret, struct net_device *dev)
case TC_ACT_SHOT:
mini_qdisc_qstats_cpu_drop(miniq);
*ret = NET_XMIT_DROP;
- kfree_skb(skb);
+ kfree_skb_reason(skb, SKB_DROP_REASON_QDISC_EGRESS);
return NULL;
case TC_ACT_STOLEN:
case TC_ACT_QUEUED:
--
2.34.1