Re: [PATCHv2 22/29] x86/tdx: Make pages shared in ioremap()

From: Dave Hansen
Date: Tue Feb 15 2022 - 11:35:01 EST


On 2/15/22 08:27, Kirill A. Shutemov wrote:
>>> But with u64 as type, I'm not sure 'pgprot' in the name is jutified.
>> Maybe cc_mask_{enc,dec}()? It just sounds like cc_{enc,dec}() is actually
>> performing encryption or decryption and can be confusing.
> cc_{enc,dec}_mask() sounds better to me.

The pte_mk*() functions might be a good naming model here. Some of them
clear bits and some set them, but they all "make" a PTE.