Re: [PATCH net v3] net: Force inlining of checksum functions in net/checksum.h
From: Masahiro Yamada
Date: Thu Feb 17 2022 - 20:36:54 EST
On Fri, Feb 18, 2022 at 3:10 AM Segher Boessenkool
<segher@xxxxxxxxxxxxxxxxxxx> wrote:
>
> On Fri, Feb 18, 2022 at 02:27:16AM +0900, Masahiro Yamada wrote:
> > On Fri, Feb 18, 2022 at 1:49 AM David Laight <David.Laight@xxxxxxxxxx> wrote:
> > > That description is largely fine.
> > >
> > > Inappropriate 'inline' ought to be removed.
> > > Then 'inline' means - 'really do inline this'.
> >
> > You cannot change "static inline" to "static"
> > in header files.
>
> Why not? Those two have identical semantics!
e.g.)
[1] Open include/linux/device.h with your favorite editor,
then edit
static inline void *devm_kcalloc(struct device *dev,
to
static void *devm_kcalloc(struct device *dev,
[2] Build the kernel
>
>
> Segher
--
Best Regards
Masahiro Yamada