On Tue, Feb 22, 2022 at 11:59:26AM +0000, Srinivas Kandagatla wrote:Thanks for spotting this, Yes, that is another issue, Will fix those in next spin.
wcd934x_rx_hph_mode_put currently returns zero eventhough it changes the value.
Fix this, so that change notifications are sent correctly.
- return 0;
+ return 1;
This now has the opposite issue where it will unconditionally flag a
change even if none occurred, that's less bad but still an issue. It
should check to see if the value written is different to that already
set and report that.