Re: [PATCH v2 09/15] scsi: ufs: deprecate 'freq-table-hz' property

From: Krzysztof Kozlowski
Date: Wed Feb 23 2022 - 03:24:09 EST


On 22/02/2022 17:44, Alim Akhtar wrote:
> Hi Krzysztof
>
>> -----Original Message-----
>> From: Krzysztof Kozlowski [mailto:krzysztof.kozlowski@xxxxxxxxxxxxx]
>> Sent: Tuesday, February 22, 2022 8:29 PM
>> To: Alim Akhtar <alim.akhtar@xxxxxxxxxxx>; Avri Altman
>> <avri.altman@xxxxxxx>; Rob Herring <robh+dt@xxxxxxxxxx>; Krzysztof
>> Kozlowski <krzysztof.kozlowski@xxxxxxxxxxxxx>; Andy Gross
>> <agross@xxxxxxxxxx>; Bjorn Andersson <bjorn.andersson@xxxxxxxxxx>; Wei
>> Xu <xuwei5@xxxxxxxxxxxxx>; Nishanth Menon <nm@xxxxxx>; Vignesh
>> Raghavendra <vigneshr@xxxxxx>; Tero Kristo <kristo@xxxxxxxxxx>; James E.J.
>> Bottomley <jejb@xxxxxxxxxxxxx>; Martin K. Petersen
>> <martin.petersen@xxxxxxxxxx>; Jan Kotas <jank@xxxxxxxxxxx>; Li Wei
>> <liwei213@xxxxxxxxxx>; Stanley Chu <stanley.chu@xxxxxxxxxxxx>; Yaniv
>> Gardi <ygardi@xxxxxxxxxxxxxx>; linux-scsi@xxxxxxxxxxxxxxx;
>> devicetree@xxxxxxxxxxxxxxx; linux-kernel@xxxxxxxxxxxxxxx; linux-arm-
>> msm@xxxxxxxxxxxxxxx; linux-arm-kernel@xxxxxxxxxxxxxxxxxxx; linux-samsung-
>> soc@xxxxxxxxxxxxxxx; linux-mediatek@xxxxxxxxxxxxxxxxxxx
>> Subject: [PATCH v2 09/15] scsi: ufs: deprecate 'freq-table-hz' property
>>
>> The 'freq-table-hz' is not correct in DT schema, because '-hz' suffix
> defines
>> uint32 type, not an array. Therefore deprecate 'freq-table-hz'
>> and use 'freq-table' instead.
>>
> May be once all the dts change migrate to using 'freq-table', just remove
> 'freq-table-hz' from driver.

At some point in the future 'freq-table-hz' parsing could be removed,
but now you have both old and new DTS, so it should stay. Also for DTB
compatibility.


Best regards,
Krzysztof