Re: [PATCH v1 1/2] arm64: dts: imx8mn-evk: use proper names for PMIC outputs

[Michael Walle]

Am 2022-02-24 08:29, schrieb Heiko Thiery:
> Hi,
>
> Am Mi., 23. Feb. 2022 um 22:06 Uhr schrieb Michael Walle 
> <michael@xxxxxxxx>:
> > Use the power signal names as given in the schematics of the reference
> > board.
> >
> > Signed-off-by: Michael Walle <michael@xxxxxxxx>
> > ---
> >  arch/arm64/boot/dts/freescale/imx8mn-evk.dts | 20 
> > ++++++++++----------
> >  1 file changed, 10 insertions(+), 10 deletions(-)
> >
> > diff --git a/arch/arm64/boot/dts/freescale/imx8mn-evk.dts 
> > b/arch/arm64/boot/dts/freescale/imx8mn-evk.dts
> > index b4225cfcb6d9..eaa06f49aef5 100644
> > --- a/arch/arm64/boot/dts/freescale/imx8mn-evk.dts
> > +++ b/arch/arm64/boot/dts/freescale/imx8mn-evk.dts
> > @@ -41,7 +41,7 @@ pmic: pmic@25 {
> >
> >                 regulators {
> >                         buck1: BUCK1{
> > -                               regulator-name = "BUCK1";
> > +                               regulator-name = "VDD_ARM_0V9";
>
> I think BUCK1 and BUCK2 are twisted here. This should be "VDD_SOC".
>
> >                                 regulator-min-microvolt = <600000>;
> >                                 regulator-max-microvolt = <2187500>;
> >                                 regulator-boot-on;
> > @@ -50,7 +50,7 @@ buck1: BUCK1{
> >                         };
> >
> >                         buck2: BUCK2 {
> > -                               regulator-name = "BUCK2";
> > +                               regulator-name = "VDD_SOC";
>
> And this should be "VDD_ARM_0V9".

You are absolutely right. I noticed it on the 8MNANOD3L-EVK but
forgot to update these.

-michael