Re: [PATCH] power: supply: sbs-charger: Don't cancel work that is not initialized

From: Sebastian Reichel
Date: Thu Feb 24 2022 - 06:23:19 EST


Hi,

On Sun, Feb 13, 2022 at 06:07:03PM +0100, Christophe JAILLET wrote:
> This driver can use an interrupt or polling in order get the charger's
> status.
>
> When using polling, a delayed work is used.
>
> However, the remove() function unconditionally call
> cancel_delayed_work_sync(), even if the delayed work is not used and is not
> initialized.
>
> In order to fix it, use devm_delayed_work_autocancel() and remove the now
> useless remove() function.
>
> Fixes: feb583e37f8a ("power: supply: add sbs-charger driver")
> Signed-off-by: Christophe JAILLET <christophe.jaillet@xxxxxxxxxx>
> ---

Thanks, queued.

-- Sebastian

Attachment: signature.asc
Description: PGP signature