Re: [PATCH 1/3] pwm-sun4i: convert "next_period" to local variable
From: Thierry Reding
Date: Thu Feb 24 2022 - 08:05:01 EST
On Tue, Jan 25, 2022 at 03:31:58PM +0100, Uwe Kleine-König wrote:
> Hello,
>
> On Tue, Jan 25, 2022 at 01:34:27PM +0100, Max Kellermann wrote:
> > Its value is calculated in sun4i_pwm_apply() and is used only there.
> >
> > Cc: stable@xxxxxxxxxxxxxxx
>
> I think I'd drop this. This isn't a fix worth on it's own to be
> backported and if this is needed for one of the next patches, the stable
> maintainers will notice themselves (and it might be worth to shuffle
> this series to make the fixes come first).
>
> > Signed-off-by: Max Kellermann <max.kellermann@xxxxxxxxx>
>
> Other than that, LGTM:
>
> Reviewed-by: Uwe Kleine-König <u.kleine-koenig@xxxxxxxxxxxxxx>
Does that apply to patches 2 & 3 as well?
Thierry
Attachment:
signature.asc
Description: PGP signature