Re: [PATCH 2/3] powerpc: fix build errors
From: Segher Boessenkool
Date: Thu Feb 24 2022 - 12:17:34 EST
On Thu, Feb 24, 2022 at 03:05:28PM +1000, Nicholas Piggin wrote:
> + * gcc 10 started to emit a .machine directive at the beginning of generated
> + * .s files, which overrides assembler -Wa,-m<cpu> options passed down.
> + * Unclear if this behaviour will be reverted.
It will not be reverted. If you need a certain .machine for some asm
code, you should write just that!
> +#ifdef CONFIG_CC_IS_GCC
> +#if (GCC_VERSION >= 100000)
> +#if (CONFIG_AS_VERSION == 23800)
> +asm(".machine any");
> +#endif
> +#endif
> +#endif
> +#endif /* __ASSEMBLY__ */
Abusing toplevel asm like this is broken and you *will* end up with
unhappiness all around.
Segher