Re: [PATCH RFC 06/13] mm/rmap: pass rmap flags to hugepage_add_anon_rmap()

From: Linus Torvalds
Date: Thu Feb 24 2022 - 12:42:51 EST


On Thu, Feb 24, 2022 at 4:30 AM David Hildenbrand <david@xxxxxxxxxx> wrote:
>
> - hugepage_add_anon_rmap(new, vma, pvmw.address);
> + hugepage_add_anon_rmap(new, vma, pvmw.address, 0);

This now has the same "what does 0 mean?" issue.

(And grepping for RMAP_, I notice that we have a namespace clash, with
xfs and kvm also using "RMAP_xyz" for their own things. Oh wel, at
least they don't look like they'd ever mix).

Linus