Re: [PATCH] [PATCH] AARCH64: Add gcc Shadow Call Stack support

From: Dan Li
Date: Thu Feb 24 2022 - 19:35:22 EST




On 2/23/22 09:39, Nathan Chancellor wrote:
On Wed, Feb 23, 2022 at 12:50:21AM -0800, Dan Li wrote:
My intention is to remind users that this is a compiler feature.
But since there is also a hint in CC_HAVE_SHADOW_CALL_STACK:
+# Supported by clang >= 7.0 or GCC ...

Removing the specific compiler here also looks fine to me.
Would this look better?

"This option enables Shadow Call Stack, which uses a ..."

or maybe:

"This option enables compiler's Shadow Call Stack, which uses a ..."

I do not honestly have a strong opinion around removing mention of the
compiler so either looks fine to me (might be better to say "the
compiler's Shadow ..." in the second one).


Ah, yes, thanks :)

Dan.