Re: [PATCH v2 21/39] x86/ibt: Annotate text references
From: Josh Poimboeuf
Date: Thu Feb 24 2022 - 19:47:27 EST
On Thu, Feb 24, 2022 at 03:51:59PM +0100, Peter Zijlstra wrote:
> @@ -563,12 +564,14 @@ SYM_CODE_END(\asmsym)
> .align 16
> .globl __irqentry_text_start
> __irqentry_text_start:
> + ANNOTATE_NOENDBR // unwinders
But the instruction here (first idt entry) actually does have an
endbr64...
Also I'm wondering if it would make sense to create an
'idt_entry_<vector>' symbol for each entry so objtool knows to validate
their ENDBRs.
> +++ b/arch/x86/lib/retpoline.S
> @@ -12,6 +12,8 @@
>
> .section .text.__x86.indirect_thunk
>
> + ANNOTATE_NOENDBR // apply_retpolines
This should probably go after __x86_indirect_thunk_array?
--
Josh