Re: [PATCH v3] net/tcp: Merge TCP-MD5 inbound callbacks

[David Ahern]

On 2/23/22 10:57 AM, Dmitry Safonov wrote:
> The functions do essentially the same work to verify TCP-MD5 sign.
> Code can be merged into one family-independent function in order to
> reduce copy'n'paste and generated code.
> Later with TCP-AO option added, this will allow to create one function
> that's responsible for segment verification, that will have all the
> different checks for MD5/AO/non-signed packets, which in turn will help
> to see checks for all corner-cases in one function, rather than spread
> around different families and functions.
> 
> Cc: Eric Dumazet <edumazet@xxxxxxxxxx>
> Cc: "David S. Miller" <davem@xxxxxxxxxxxxx>
> Cc: Jakub Kicinski <kuba@xxxxxxxxxx>
> Cc: Hideaki YOSHIFUJI <yoshfuji@xxxxxxxxxxxxxx>
> Cc: David Ahern <dsahern@xxxxxxxxxx>
> Cc: netdev@xxxxxxxxxxxxxxx
> Signed-off-by: Dmitry Safonov <dima@xxxxxxxxxx>
> ---
> v2: Rebased on net-next
> v3: Correct rebase on net-next for !CONFIG_TCP_MD5
> 
>  include/net/tcp.h   | 13 ++++++++
>  net/ipv4/tcp.c      | 70 ++++++++++++++++++++++++++++++++++++++++
>  net/ipv4/tcp_ipv4.c | 78 +++------------------------------------------
>  net/ipv6/tcp_ipv6.c | 62 +++--------------------------------
>  4 files changed, 92 insertions(+), 131 deletions(-)
> 


Reviewed-by: David Ahern <dsahern@xxxxxxxxxx>