Re: [PATCH V2] staging: rts5208: fix Lines should not end with a '('.

From: Greg Kroah-Hartman
Date: Fri Feb 25 2022 - 04:01:13 EST


On Mon, Feb 21, 2022 at 10:43:44PM +0100, Samuel Sjöberg wrote:
> Fix the following error reported by checkpatch.pl:
>
> CHECK: Lines should not end with a '('
> + retval = ms_transfer_tpc(
>
> Signed-off-by: Samuel Sjöberg <info@xxxxxxxxxxxxxxxx>
> ---
> Changes in v2:
> - Fixed subject line and commit message.
>
> drivers/staging/rts5208/ms.c | 9 ++++-----
> 1 file changed, 4 insertions(+), 5 deletions(-)
>
> diff --git a/drivers/staging/rts5208/ms.c b/drivers/staging/rts5208/ms.c
> index 2a6fab5c117a..14449f8afad5 100644
> --- a/drivers/staging/rts5208/ms.c
> +++ b/drivers/staging/rts5208/ms.c
> @@ -1749,11 +1749,10 @@ static int ms_copy_page(struct rtsx_chip *chip, u16 old_blk, u16 new_blk,
>
> for (rty_cnt = 0; rty_cnt < MS_MAX_RETRY_COUNT;
> rty_cnt++) {
> - retval = ms_transfer_tpc(
> - chip,
> - MS_TM_NORMAL_WRITE,
> - WRITE_PAGE_DATA,
> - 0, NO_WAIT_INT);
> + retval = ms_transfer_tpc(chip,
> + MS_TM_NORMAL_WRITE,
> + WRITE_PAGE_DATA,
> + 0, NO_WAIT_INT);
> if (retval == STATUS_SUCCESS)
> break;
> }
> --
> 2.35.1
>

This change never ended up on the mailing list for some reason :(

Please fix up and resend.

thanks,

greg k-h