Re: [PATCH 1/1] usb: gadget: tegra-xudc: Fix control endpoint's definitions

[Thierry Reding]

On Fri, Jan 07, 2022 at 05:13:49PM +0800, Wayne Chang wrote:
> According to the Tegra Technical Reference Manual, the seq_num
> field of control endpoint is not [31:24] but [31:27]. Bit 24
> is reserved and bit 26 is splitxstate.
> 
> The change fixes the wrong control endpoint's definitions.
> 
> Signed-off-by: Wayne Chang <waynec@xxxxxxxxxx>
> ---
>  drivers/usb/gadget/udc/tegra-xudc.c | 12 ++++++++++--
>  1 file changed, 10 insertions(+), 2 deletions(-)

Again, what's the impact of this? Is this a critical bug fix that needs
to go into stable? Or is it cleanup? Perhaps add something along those
lines to the commit message to make it clearer to maintainers how they
need to deal with them.

Also, if this is a bugfix, make sure to Cc: stable@xxxxxxxxxxxxxxx and
add a corresponding Fixes: line. Same for that earlier patch.

Thierry

Attachment: signature.asc
Description: PGP signature