Re: [PATCH net-next 1/3] net: ip: add skb drop reasons for ip egress path

[Menglong Dong]

On Fri, Feb 25, 2022 at 9:41 PM Roman Mashak <mrv@xxxxxxxxxxxx> wrote:
>
> Menglong Dong <menglong8.dong@xxxxxxxxx> writes:
>
> > On Tue, Feb 22, 2022 at 11:13 AM David Ahern <dsahern@xxxxxxxxxx> wrote:
> >>
> >> On 2/20/22 8:57 AM, menglong8.dong@xxxxxxxxx wrote:
> >> > From: Menglong Dong <imagedong@xxxxxxxxxxx>
> >> >
> >> > Replace kfree_skb() with kfree_skb_reason() in the packet egress path of
> >> > IP layer (both IPv4 and IPv6 are considered).
> >> >
> >> > Following functions are involved:
> >> >
> >> > __ip_queue_xmit()
> >> > ip_finish_output()
> >> > ip_mc_finish_output()
> >> > ip6_output()
> >> > ip6_finish_output()
> >> > ip6_finish_output2()
> >> >
> >> > Following new drop reasons are introduced:
> >> >
> >> > SKB_DROP_REASON_IP_OUTNOROUTES
> >> > SKB_DROP_REASON_BPF_CGROUP_EGRESS
> >> > SKB_DROP_REASON_IPV6DSIABLED
>
> Is this a typo and should be SKB_DROP_REASON_IPV6DISABLED ?

In fact......yeah, this is a typo :)
I'll fix it. Thanks!

>
> [...]
>