Re: [PATCH v2 00/39] x86: Kernel IBT
From: Josh Poimboeuf
Date: Fri Feb 25 2022 - 15:15:34 EST
On Fri, Feb 25, 2022 at 08:53:03PM +0100, Peter Zijlstra wrote:
> On Fri, Feb 25, 2022 at 12:32:38PM -0500, Steven Rostedt wrote:
> > On Fri, 25 Feb 2022 09:26:44 -0800
> > Josh Poimboeuf <jpoimboe@xxxxxxxxxx> wrote:
> >
> > > > Damn, I just realized this makes KERNEL_IBT hard depend on KALLSYMS :-(
> > >
> > > Why should the jump label patching code even care whether there's an
> > > ENDBR at the jump target? It should never jump to the beginning of a
> > > function anyway, right? And objtool presumably doesn't patch out ENDBRs
> > > in the middle of a function.
> >
> > Perhaps Peter confused jump labels with static calls?
>
> The code is shared between the two.
Then just have a text_gen_insn_dont_skip_endbr() or so... ?
--
Josh