Re: [PATCH v3] tracefs: Set the group ownership in apply_options() not parse_options()
From: Al Viro
Date: Fri Feb 25 2022 - 18:12:26 EST
On Fri, Feb 25, 2022 at 03:34:26PM -0500, Steven Rostedt wrote:
> From: "Steven Rostedt (Google)" <rostedt@xxxxxxxxxxx>
>
> Al Viro brought it to my attention that the dentries may not be filled
> when the parse_options() is called, causing the call to set_gid() to
> possibly crash. It should only be called if parse_options() succeeds
> totally anyway.
>
> He suggested the logical place to do the update is in apply_options().
Feel free to slap my Acked-by on that variant...