RE: [EXT] [PATCH] hwrng: cavium: fix NULL but dereferenced coccicheck error

[Sunil Kovvuri Goutham]

> -----Original Message-----
> From: Wan Jiabing <wanjiabing@xxxxxxxx>
> Sent: Friday, February 25, 2022 12:09 PM
> To: Matt Mackall <mpm@xxxxxxxxxxx>; Herbert Xu
> <herbert@xxxxxxxxxxxxxxxxxxx>; Sunil Kovvuri Goutham
> <sgoutham@xxxxxxxxxxx>; Wan Jiabing <wanjiabing@xxxxxxxx>; linux-
> crypto@xxxxxxxxxxxxxxx; linux-kernel@xxxxxxxxxxxxxxx
> Cc: jiabing.wan@xxxxxx
> Subject: [EXT] [PATCH] hwrng: cavium: fix NULL but dereferenced coccicheck
> error
> 
> External Email
> 
> ----------------------------------------------------------------------
> Fix following coccicheck warning:
> ./drivers/char/hw_random/cavium-rng-vf.c:182:17-20: ERROR:
> pdev is NULL but dereferenced.
> 
> Signed-off-by: Wan Jiabing <wanjiabing@xxxxxxxx>
> ---
>  drivers/char/hw_random/cavium-rng-vf.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/drivers/char/hw_random/cavium-rng-vf.c
> b/drivers/char/hw_random/cavium-rng-vf.c
> index 6f66919652bf..7c55f4cf4a8b 100644
> --- a/drivers/char/hw_random/cavium-rng-vf.c
> +++ b/drivers/char/hw_random/cavium-rng-vf.c
> @@ -179,7 +179,7 @@ static int cavium_map_pf_regs(struct cavium_rng
> *rng)
>  	pdev = pci_get_device(PCI_VENDOR_ID_CAVIUM,
>  			      PCI_DEVID_CAVIUM_RNG_PF, NULL);
>  	if (!pdev) {
> -		dev_err(&pdev->dev, "Cannot find RNG PF device\n");
> +		pr_err("Cannot find RNG PF device\n");
>  		return -EIO;
>  	}
> 
> --

Thanks for the fix.
Reviewed-by: Sunil Goutham <sgoutham@xxxxxxxxxxx>