Re: [PATCH 4/6] block, bio, fs: convert most filesystems to pin_user_pages_fast()

From: Jens Axboe
Date: Sun Feb 27 2022 - 16:59:44 EST


On 2/27/22 2:34 AM, jhubbard.send.patches@xxxxxxxxx wrote:
> From: John Hubbard <jhubbard@xxxxxxxxxx>
>
> Use pin_user_pages_fast(), pin_user_page(), and unpin_user_page() calls,
> in place of get_user_pages_fast(), get_page() and put_page().
>
> This converts the Direct IO parts of most filesystems over to using
> FOLL_PIN (pin_user_page*()) page pinning.

The commit message needs to explain why a change is being made, not what
is being done. The latter I can just look at the code for.

Didn't even find it in in your cover letter, had to go to the original
posting for that.

--
Jens Axboe