[PATCH] powerpc: kernel: fix a refcount leak in format_show()

From: Hangyu Hua
Date: Mon Feb 28 2022 - 04:11:31 EST


node needs to be dropped when of_property_read_string fails. So an earlier call
to of_node_put is required here.

Signed-off-by: Hangyu Hua <hbh25y@xxxxxxxxx>
---
arch/powerpc/kernel/secvar-sysfs.c | 3 +--
1 file changed, 1 insertion(+), 2 deletions(-)

diff --git a/arch/powerpc/kernel/secvar-sysfs.c b/arch/powerpc/kernel/secvar-sysfs.c
index a0a78aba2083..cd0fa7028d86 100644
--- a/arch/powerpc/kernel/secvar-sysfs.c
+++ b/arch/powerpc/kernel/secvar-sysfs.c
@@ -30,13 +30,12 @@ static ssize_t format_show(struct kobject *kobj, struct kobj_attribute *attr,
return -ENODEV;

rc = of_property_read_string(node, "format", &format);
+ of_node_put(node);
if (rc)
return rc;

rc = sprintf(buf, "%s\n", format);

- of_node_put(node);
-
return rc;
}

--
2.25.1