Re: [PATCH 2/2] mfd: arizona-spi: Add Android board ACPI table handling
From: Charles Keepax
Date: Mon Feb 28 2022 - 06:35:54 EST
On Wed, Feb 23, 2022 at 02:42:22PM +0100, Hans de Goede wrote:
> x86/ACPI boards with an arizona WM5102 codec ship with either Windows or
> Android as factory installed OS.
>
> The ACPI fwnode for the codec on Android boards misses 2 things compared
> to the Windows boards (this is hardcoded in the Android board kernels):
>
> 1. There is no CLKE ACPI method to enabe the 32 KHz clock the codec needs
> for jack-detection.
>
> 2. The GPIOs used by the codec are not listed in the fwnode for the codec.
>
> The ACPI tables on x86/ACPI boards shipped with Android being incomplete
> happens a lot. The special drivers/platform/x86/x86-android-tablets.c
> module contains DMI based per model handling to compensate for this.
>
> This module will enable the 32KHz clock through the pinctrl framework
> to fix 1. and it will also register a gpio-lookup table for all GPIOs
> needed by the codec + machine driver, including the GPIOs coming from
> the codec itself.
>
> Add an arizona_spi_acpi_android_probe() function which waits for the
> x86-android-tablets to have set things up before continue with probing
> the arizona WM5102 codec.
>
> Signed-off-by: Hans de Goede <hdegoede@xxxxxxxxxx>
> ---
Acked-by: Charles Keepax <ckeepax@xxxxxxxxxxxxxxxxxxxxx>
Thanks,
Charles