[PATCH] scsi: wd719x: Return proper error code when dma_set_mask() fails

From: Zheyu Ma
Date: Mon Feb 28 2022 - 09:54:39 EST


During the process of driver probing, the probe function should return < 0
for failure, otherwise, the kernel will treat value >= 0 as success.

Signed-off-by: Zheyu Ma <zheyuma97@xxxxxxxxx>
---
drivers/scsi/wd719x.c | 3 ++-
1 file changed, 2 insertions(+), 1 deletion(-)

diff --git a/drivers/scsi/wd719x.c b/drivers/scsi/wd719x.c
index 1a7947554581..2b24ef387d57 100644
--- a/drivers/scsi/wd719x.c
+++ b/drivers/scsi/wd719x.c
@@ -904,7 +904,8 @@ static int wd719x_pci_probe(struct pci_dev *pdev, const struct pci_device_id *d)
if (err)
goto fail;

- if (dma_set_mask(&pdev->dev, DMA_BIT_MASK(32))) {
+ err = dma_set_mask(&pdev->dev, DMA_BIT_MASK(32));
+ if (err) {
dev_warn(&pdev->dev, "Unable to set 32-bit DMA mask\n");
goto disable_device;
}
--
2.25.1