Re: [PATCH v1 net-next 1/1] net: dsa: felix: remove prevalidate_phy_mode interface

From: Colin Foster
Date: Mon Feb 28 2022 - 13:35:41 EST


On Mon, Feb 28, 2022 at 11:46:35AM +0000, Vladimir Oltean wrote:
> On Sat, Feb 26, 2022 at 02:36:50PM -0800, Colin Foster wrote:
> > All users of the felix driver were creating their own prevalidate_phy_mode
> > function. The same logic can be performed in a more general way by using a
> > simple array of bit fields.
> >
> > Signed-off-by: Colin Foster <colin.foster@xxxxxxxxxxxxxxxx>
> > Suggested-by: Vladimir Oltean <vladimir.oltean@xxxxxxx>
> > ---
>
> Reviewed-by: Vladimir Oltean <vladimir.oltean@xxxxxxx>
> Tested-by: Vladimir Oltean <vladimir.oltean@xxxxxxx>

Thanks Vladimir!

I realized I didn't respond to your feedback email from my last patch
set. My apologies - I had shifted my focus to the MFD infrastructure
changes. I hope to be able to send a new RFC soon with all improvements
both you and Lee suggested.