Re: [PATCH v2 2/2] ARM: dts: kirkwood: Add Ctera C-200 V1 board

From: Linus Walleij
Date: Mon Feb 28 2022 - 18:43:34 EST


On Tue, Feb 15, 2022 at 5:40 PM Pawel Dembicki <paweldembicki@xxxxxxxxx> wrote:

> +&i2c0 {
> + status = "okay";
> +
> + rtc@30 {
> + compatible = "s35390a";
> + reg = <0x30>;
> + };
> +
> + lm63@4c {
> + compatible = "national,lm63";
> + reg = <0x4c>;
> + };

Think about adding chassis thermal zone for this sensor,

I suppose you don't have any active control of cooling (fan)?
This often sits on GPIO...

In that case just add a critical temperature so it can't burn
down the house.

See:
arch/arm/boot/dts/gemini-dlink-dns-313.dts
node thermal-zones {} for an example of how to do this
quick and easy. You need CONFIG_THERMAL and
CONFIG_THERMAL_HWMON for this to work.

Yours,
Linus Walleij