Re: [PATCH net] net: ipa: add an interconnect dependency

From: Jakub Kicinski
Date: Tue Mar 01 2022 - 00:35:29 EST


On Sat, 26 Feb 2022 13:57:47 -0600 Alex Elder wrote:
> In order to function, the IPA driver very clearly requires the
> interconnect framework to be enabled in the kernel configuration.
> State that dependency in the Kconfig file.
>
> This became a problem when CONFIG_COMPILE_TEST support was added.
> Non-Qualcomm platforms won't necessarily enable CONFIG_INTERCONNECT.
>
> Reported-by: kernel test robot <lkp@xxxxxxxxx>
> Fixes: 38a4066f593c5 ("net: ipa: support COMPILE_TEST")
> Signed-off-by: Alex Elder <elder@xxxxxxxxxx>
> ---
> drivers/net/ipa/Kconfig | 1 +
> 1 file changed, 1 insertion(+)
>
> diff --git a/drivers/net/ipa/Kconfig b/drivers/net/ipa/Kconfig
> index d037682fb7adb..3e0da1e764718 100644
> --- a/drivers/net/ipa/Kconfig
> +++ b/drivers/net/ipa/Kconfig
> @@ -2,6 +2,7 @@ config QCOM_IPA
> tristate "Qualcomm IPA support"
> depends on NET && QCOM_SMEM
> depends on ARCH_QCOM || COMPILE_TEST
> + depends on INTERCONNECT
> depends on QCOM_RPROC_COMMON || (QCOM_RPROC_COMMON=n && COMPILE_TEST)
> select QCOM_MDT_LOADER if ARCH_QCOM
> select QCOM_SCM

Looks like this patch was based on a tree without the QCOM_AOSS_QMP
dependency patch, please rebase and repost.